Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disabled options from reappearing in Site Health after external update #1374

Merged
merged 11 commits into from
Jul 26, 2024
Merged

Fix disabled options from reappearing in Site Health after external update #1374

merged 11 commits into from
Jul 26, 2024

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #1340

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only skip changelog PRs that should not be mentioned in changelogs labels Jul 18, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Jul 18, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review July 18, 2024 06:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27
Copy link
Member Author

Thanks @westonruter for the feedback. PR ready for review.

westonruter
westonruter approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adamsilverstein
adamsilverstein approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@mukeshpanchal27 mukeshpanchal27 merged commit 8212900 into trunk Jul 26, 2024
15 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the fix/1340-auto-update-options branch July 26, 2024 04:55
@westonruter westonruter changed the title Fix disabled options reappear in Site Health after external update Fix disabled options from reappearing in Site Health after external update Aug 16, 2024
@westonruter westonruter removed the skip changelog PRs that should not be mentioned in changelogs label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@westonruter westonruter westonruter approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Bug An existing feature is broken
Projects
None yet
Milestone
performance-lab 3.4.0
Development

Successfully merging this pull request may close these issues.

Autoloaded Options Health Check: Disabled options reappear in Site Health after external update
4 participants
@mukeshpanchal27 @westonruter @swissspidy @adamsilverstein